-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate modifying class parameters #811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, I haven't reviewed the full implementation, but that's the idea. So that only people that changed a class parameter get the deprecation message.
6e76da7
to
ca11d91
Compare
Just noted that we can deprecate parameters.
|
I didn't know about that, but apparently it's only available since 6.3: symfony/symfony#47719 |
Ok, so we can detect if That would be more simple than the conditional warning added in this PR. |
This is a good point 👍 |
7530f80
to
2b87ebe
Compare
After trying this, not sure if we can use |
Weird, how Symfony suggests to use this deprecation then? |
Maybe we can deprecate the parameters only in the next major version, once they are no longer used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM as this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oups, you should revert to the previous implementation.
5fa3808
to
9f2c918
Compare
9f2c918
to
23da11f
Compare
23da11f
to
3af9a28
Compare
Thank you @franmomu |
Ref #810 (comment)
@GromNaN do you mean something like this?